Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

Asana Task/Github Issue:

Description

Fixes a flaky favicon + monitor (many updates) integration test. The test previously asserted an exact number of faviconFound messages at an intermediate time, which was unreliable due to the feature's debounce logic and rapid updates under a mocked clock. This change updates the test to fast-forward the mocked clock past all updates and debounces, then asserts on the first and final faviconFound payloads to ensure deterministic validation of the initial and eventual states.

Testing Steps

  • Run npx playwright test injected/integration-test/favicon.spec.js

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Open in Cursor Open in Web

Co-authored-by: jkingston <jkingston@duckduckgo.com>
@cursor
Copy link

cursor bot commented Dec 19, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 587bac2
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/694562d1b575c40008400efe
😎 Deploy Preview https://deploy-preview-2129--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

[Beta] Generated file diff

Time updated: Fri, 19 Dec 2025 14:37:10 GMT

Co-authored-by: jkingston <jkingston@duckduckgo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants