-
Notifications
You must be signed in to change notification settings - Fork 31
Change apple message exposure #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonathanKingston
wants to merge
22
commits into
main
Choose a base branch
from
jkt/change-apple-message-exposure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
Contributor
[Beta] Generated file diffTime updated: Fri, 19 Dec 2025 18:29:38 GMT Android
File has changed Apple
File has changed Chrome-mv3File has changed FirefoxFile has changed Integration
File has changed Windows
File has changed |
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: jkingston <jkingston@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/481882893211075/task/1212500741100132?focus=true
Description
Relies on duckduckgo/apple-browsers#2946
Testing Steps
Checklist
Please tick all that apply:
Note
Routes WebKit messaging callbacks/subscriptions through
navigator.duckduckgo, adds a utility to ensure it exists, refactors the navigator interface, expands captured globals, updates types, and adjusts tests accordingly.navigator.duckduckgo[...]instead ofwindow[...]inmessaging/lib/webkit.js.injected/src/captured-globals.js; minor refactors (e.g.,decryptResponse, internal handler storage).injected/src/navigator-global.jswithensureNavigatorDuckDuckGoto create/returnnavigator.duckduckgo.injected/src/features/navigator-interface.jsto initializenavigator.duckduckgo(exposeplatform,isDuckDuckGo,createMessageBridge) and avoid re-init.injected/src/captured-globals.js(encoders, typed arrays, JSON helpers, crypto, Reflect, etc.).messaging/lib/messaging.types.d.tsto includeNavigator['duckduckgo']and test-time handlers onWindow.navigator.duckduckgowith window fallback.navigator.duckduckgohandlers, assert per-feature messaging, and add small routing tweaks for special pages.Written by Cursor Bugbot for commit 5751b29. This will update automatically on new commits. Configure here.