This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Only fire autofill toggled state pixels when device authentication is enabled#1010
Open
Only fire autofill toggled state pixels when device authentication is enabled#1010
Conversation
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
…auth-pixel-changes # Conflicts: # Tests/BrowserServicesKitTests/Autofill/AutofillPixelReporterTests.swift
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1201462886803403/1208356133120985/f
iOS PR:
macOS PR:
What kind of version bump will this require?: Minor
Description:
If users do not have some form of device authentication enabled, then prevent the autofill toggle state pixels from firing as this data is irrelevant since they cannot utilised autofill
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template