Skip to content

Conversation

@maiadegraaf
Copy link
Contributor

This PR applies patches from duckdb/duckdb:

  • fix.patch

Copy link
Collaborator

@staticlibs staticlibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me!

In general, such automated (or to-be-automated) application of patches from duckdb/duckdb repo can go in assuming the CI tests have passed. I've added the CI run of the SQLite extension test-suite in #172, so we now have some coverage.

Apparently, when patches are applied, the patched extension is only buildable when the duckdb submodule also has been updated. So this PR needs to be paired with #171 one. I suggest to rebase both of PRs on top of the latest main (that includes #172) and then either to combine the PRs into one or to merge the prerequisite PR first and merge the main one after the CI passes.

When merging a PR with a single commit - please just rebase such commit (second merge commit adds no value in this case). For multi-commit merges - please choose the method that is more convenient.

@staticlibs staticlibs mentioned this pull request Jan 21, 2026
@staticlibs staticlibs merged commit 1915dfe into duckdb:main Jan 22, 2026
22 checks passed
@maiadegraaf maiadegraaf deleted the apply-patches-1d5adb3128637fe1e1404ab06f720199 branch January 22, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants