Skip to content

Fix version comparison bug #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nwest wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix version comparison bug #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PODS:
- Nimble (8.0.5)
- Quick (2.2.0)
- SwiftLint (0.39.1)
- Nimble (9.2.0)
- Quick (4.0.0)
- SwiftLint (0.43.1)

DEPENDENCIES:
- Nimble
Expand All @@ -15,9 +15,9 @@ SPEC REPOS:
- SwiftLint

SPEC CHECKSUMS:
Nimble: 4ab1aeb9b45553c75b9687196b0fa0713170a332
Quick: 7fb19e13be07b5dfb3b90d4f9824c855a11af40e
SwiftLint: 55e96a4a4d537d4a3156859fc1c54bd24851a046
Nimble: 4f4a345c80b503b3ea13606a4f98405974ee4d0b
Quick: 6473349e43b9271a8d43839d9ba1c442ed1b7ac4
SwiftLint: 99f82d07b837b942dd563c668de129a03fc3fb52

PODFILE CHECKSUM: 6493f06e6fe41c0c977e06d44357670ec2485530

Expand Down
4 changes: 2 additions & 2 deletions Source/LaunchGate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public class LaunchGate {
func shouldShowOptionalUpdateDialog(_ updateConfig: UpdateConfiguration, appVersion: String) -> Bool {
guard updateConfig.isNotRemembered() else { return false }

return appVersion < updateConfig.version
return appVersion.compare(updateConfig.version, options: .numeric) == .orderedAscending
}

/**
Expand All @@ -113,7 +113,7 @@ public class LaunchGate {
- Returns: `true`, if a required update dialog should be displayed; `false`, if not.
*/
func shouldShowRequiredUpdateDialog(_ updateConfig: UpdateConfiguration, appVersion: String) -> Bool {
appVersion < updateConfig.version
appVersion.compare(updateConfig.version, options: .numeric) == .orderedAscending
}

func currentAppVersion() -> String? {
Expand Down