Attachment support #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 3, 2020
| - body: Custom email body (plain text). | ||
| */ | ||
| public class func configure(to recipients: [String], subject: String?, body: String? = nil) { | ||
| public class func configure(to recipients: [String], subject: String?, body: String? = nil, attachments: (() -> [MailAttachment])? = nil) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 143 characters (line_length)
|
|
||
| let attachment = BugShaker.MailAttachment(data: try! Data(contentsOf: file), mimeType: "text/plain", fileName: fileName) | ||
|
|
||
| BugShaker.configure(to: [ "example@email.com" ], subject: "Bug Report", body: "Hi Developers, I am reporting a bug where...", attachments: [attachment]) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 156 characters (line_length)
|
|
||
| try! fileContent.write(to: file, atomically: true, encoding: .utf8) | ||
|
|
||
| let attachment = BugShaker.MailAttachment(data: try! Data(contentsOf: file), mimeType: "text/plain", fileName: fileName) |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
Line Length Violation: Line should be 120 characters or less: currently 124 characters (line_length)
| let fileContent = "This is the content of the file." | ||
| let file = FileManager.default.urls(for: .cachesDirectory, in: .userDomainMask)[0].appendingPathComponent(fileName) | ||
|
|
||
| try! fileContent.write(to: file, atomically: true, encoding: .utf8) |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to attach files (e. g. log files) to the message.