Use type alias for UnsafeCell and AtomicBool#88
Merged
dtolnay merged 1 commit intodtolnay:masterfrom Mar 28, 2026
Merged
Conversation
…gs for disallowed types in user code
elBoberido
force-pushed
the
use-type-alias-for-unsafecell-and-atomic-bool
branch
from
ed51c9e to
5177486
Compare
Contributor
Author
|
Thanks for the quick merge. I'll probably create another PR on Monday or Tuesday to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to
loom, we disallow the direct usage ofUnsafeCellandAtomic*in our code and require to use a type alias which switches the types at a central location.Since the
__submitmacro contains these two types, clippy warns when we use theinventorycrate to collect all of our test cases for a custom test harness.The PR introduces type aliases for
UnsafeCellandAtomicBool. This keeps clippy happy and does not generate warnings in the user code.