feat: add lumostories.com parser#2570
Merged
dteviot merged 1 commit intodteviot:ExperimentalTabModefrom Mar 24, 2026
Merged
Conversation
dteviot
reviewed
Mar 24, 2026
| //https://lumostories.com/en/story/216/chapters/ | ||
| if (dom.baseURI.endsWith("/chapters/") || dom.baseURI.endsWith("/chapters")) { | ||
| let uriArray = dom.baseURI.split("/").filter(Boolean); | ||
| let id = uriArray[uriArray.length - 2]; |
Owner
There was a problem hiding this comment.
Is length - 2 going to work? That assumes there's a trailing '/' when not there, needs to be - 1
Should probably add '/' if not there, then run e.g.
let url = dom.baseURI;
if (!url.endsWith("/") {
url += "/"
}
if (dom.baseURI.endsWith("/chapters/"))
...etc
```
Actually, can simplify this and the case of https://lumostories.com/en/story/216/
Whole function can be
````javascript
getBookId(dom) {
return dom.baseURI.split("/")[5];
}
```
Owner
|
Accepted. I'll fix getBookId() later today Thank you for your efforts. |
Owner
Crn0
commented
Mar 24, 2026
| parserFactory.register("api.lumostories.com", () => new LumosStoriesParer()); | ||
|
|
||
|
|
||
| class LumosStoriesParer extends Parser { |
Contributor
Author
There was a problem hiding this comment.
I just noticed it right now, but it looks like I misspelled 'Parser' in this. I will do a quick commit to change this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added LumosStoriesParer for https://lumostories.com/
resolves #2267, #2333 and #2373