Symmetrically remove prior covariance when initializing from measurement #1241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the covariance matrix generated by
SimpleMeasurementInitiatiorzeros only rows of the prior covariance. This is a non-symmetric operation, and the resulting covariance matrix thus also becomes non-symmetric. I understand the logic here as "do not add prior covariance to observed dimensions", hence prior covariances between observed dimensions and non-observed should also be removed.Another option is to only remove prior covariance between observed dimensions, that would be