Skip to content

Fix the cleartext error when updating currency rates #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbarashkov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the cleartext error when updating currency rates #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/ru/orangesoftware/financisto/rates/FreeCurrencyRateDownloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@ private ExchangeRate createRate(Currency fromCurrency, Currency toCurrency) {
}

private String buildUrl (Currency fromCurrency, Currency toCurrency) {
return "http://freecurrencyrates.com/api/action.php?s=fcr&iso="+toCurrency.name+"&f="+fromCurrency.name+"&v=1&do=cvals";
return "https://freecurrencyrates.com/api/action.php?s=fcr&iso="+toCurrency.name+"&f="+fromCurrency.name+"&v=1&do=cvals";
}
}
2 changes: 1 addition & 1 deletion app/src/main/java/ru/orangesoftware/financisto/rates/OpenExchangeRatesDownloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
public class OpenExchangeRatesDownloader extends AbstractMultipleRatesDownloader {

private static final String TAG = OpenExchangeRatesDownloader.class.getSimpleName();
private static final String GET_LATEST = "http://openexchangerates.org/api/latest.json?app_id=";
private static final String GET_LATEST = "https://openexchangerates.org/api/latest.json?app_id=";

private final String appId;
private final HttpClientWrapper httpClient;
Expand Down
2 changes: 1 addition & 1 deletion app/src/test/java/ru/orangesoftware/financisto/rates/OpenExchangeRatesDownloaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ ExchangeRateProvider service() {
@Test
public void should_download_single_rate_usd_to_cur() {
//given
givenResponseFromWebService("http://openexchangerates.org/api/latest.json?app_id=MY_APP_ID",
givenResponseFromWebService("https://openexchangerates.org/api/latest.json?app_id=MY_APP_ID",
"open_exchange_normal_response.json");
//when
ExchangeRate downloadedExchangeRate = downloadRate("USD", "SGD");
Expand Down
4 changes: 2 additions & 2 deletions app/src/test/resources/open_exchange_normal_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"disclaimer": "Exchange rates are provided for informational purposes only, and do not constitute financial advice of any kind. Although every attempt is made to ensure quality, NO guarantees are given whatsoever of accuracy, validity, availability, or fitness for any purpose - please use at your own risk. All usage is subject to your acceptance of the Terms and Conditions of Service, available at: http://openexchangerates.org/terms/",
"license": "Data sourced from various providers with public-facing APIs; copyright may apply; resale is prohibited; no warranties given of any kind. All usage is subject to your acceptance of the License Agreement available at: http://openexchangerates.org/license/",
"disclaimer": "Exchange rates are provided for informational purposes only, and do not constitute financial advice of any kind. Although every attempt is made to ensure quality, NO guarantees are given whatsoever of accuracy, validity, availability, or fitness for any purpose - please use at your own risk. All usage is subject to your acceptance of the Terms and Conditions of Service, available at: https://openexchangerates.org/terms/",
"license": "Data sourced from various providers with public-facing APIs; copyright may apply; resale is prohibited; no warranties given of any kind. All usage is subject to your acceptance of the License Agreement available at: https://openexchangerates.org/license/",
"timestamp": 1361034009,
"base": "USD",
"rates": {
Expand Down