Merged
Conversation
The CLI command stride data-tables show was not filtering the table for the project's country.
There was a problem hiding this comment.
Pull request overview
This PR fixes the stride data-tables show CLI command to correctly filter data by the project's country. Previously, the command would show data for all countries in the dataset, rather than just the country specified in the project configuration.
Changes:
- Modified
show_data_tablemethod to enable country filtering - Enhanced
_show_tablemethod to conditionally filter by geography column - Added
_table_has_geography_columnhelper method to check for geography column existence - Added comprehensive test to verify country filtering behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_project.py | Adds test to verify data-tables show command filters by project country |
| src/stride/project.py | Implements country filtering logic for show_data_table command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elainethale
reviewed
Jan 30, 2026
daniel-thom
commented
Jan 30, 2026
elainethale
approved these changes
Jan 30, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 30, 2026
* Fix show data-table command The CLI command stride data-tables show was not filtering the table for the project's country, model years, and weather year.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI command stride data-tables show was not filtering the table for the project's country.