Fci auto with debug higher order #45
Conversation
mesh may not be initialised or be a different mesh
Use the new track feature (better name required) to dump the different components of the ddt() as well as the residuum for the evolved fields.
This keeps track of all the changes done to the field and stores them to a OptionsObject.
This keeps track of all the changes done to the field and stores them to a OptionsObject.
This allows to also run the tests with 3D metrics. It also tightens the tollerances, as this is a regression test. Also removing the preconditioner is needed.
This reverts commit 8485353. The parallel metric components are loaded, thus we can take meaningful derivatives in y-direction.
Directly iterate over the points
This avoids errors in the MMS tests
This partially reverts 0bcc047 It seems the achieved accuracy depends on some factors that are not well controlled.
Likely this is not needed.
…ci-auto-with-debug-higher-order
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ******************************************************************/ | ||
|
|
||
| #define PVODE_BAND_ELEM(A,i,j) ((A->data)[j][i-j+(A->smu)]) | ||
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) |
There was a problem hiding this comment.
warning: function-like macro 'PVODE_BAND_ELEM' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)])
^| ******************************************************************/ | ||
|
|
||
| #define PVODE_BAND_ELEM(A,i,j) ((A->data)[j][i-j+(A->smu)]) | ||
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) |
There was a problem hiding this comment.
warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) | |
| #define PVODE_BAND_ELEM(A, i, j) (((A)->data)[j][i - j + (A->smu)]) |
| ******************************************************************/ | ||
|
|
||
| #define PVODE_BAND_ELEM(A,i,j) ((A->data)[j][i-j+(A->smu)]) | ||
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) |
There was a problem hiding this comment.
warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) | |
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][(i) - j + (A->smu)]) |
| ******************************************************************/ | ||
|
|
||
| #define PVODE_BAND_ELEM(A,i,j) ((A->data)[j][i-j+(A->smu)]) | ||
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) |
There was a problem hiding this comment.
warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) | |
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - (j) + (A->smu)]) |
| ******************************************************************/ | ||
|
|
||
| #define PVODE_BAND_ELEM(A,i,j) ((A->data)[j][i-j+(A->smu)]) | ||
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) |
There was a problem hiding this comment.
warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + (A->smu)]) | |
| #define PVODE_BAND_ELEM(A, i, j) ((A->data)[j][i - j + ((A)->smu)]) |
| int abs_offset() const { return 1; } | ||
|
|
||
| #if BOUT_USE_METRIC_3D == 0 | ||
| BoutReal& ynext(Field2D& f) const { return f[ind().yp(by).xp(bx)]; } |
There was a problem hiding this comment.
warning: no header providing "Field2D" is directly included [misc-include-cleaner]
include/bout/boundary_iterator.hxx:2:
- #include "bout/mesh.hxx"
+ #include "bout/field2d.hxx"
+ #include "bout/mesh.hxx"| const BoutReal& yprev(const Field2D& f) const { return f[ind().yp(-by).xp(-bx)]; } | ||
| #endif | ||
|
|
||
| const int dir; |
There was a problem hiding this comment.
warning: member 'dir' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
const int dir;
^| const BoutReal& yprev(const Field2D& f) const { return f[ind().yp(-by).xp(-bx)]; } | ||
| #endif | ||
|
|
||
| const int dir; |
There was a problem hiding this comment.
warning: member variable 'dir' has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
const int dir;
^| const int dir; | ||
|
|
||
| protected: | ||
| int z{0}; |
There was a problem hiding this comment.
warning: member variable 'z' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]
int z{0};
^|
|
||
| protected: | ||
| int z{0}; | ||
| int x; |
There was a problem hiding this comment.
warning: member variable 'x' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]
int x;
^That might format more code at once, but should avoid a CI loop.
dschwoerer
force-pushed
the
fci-auto-with-debug-higher-order
branch
from
fda08d2 to
eef32f9
Compare
No description provided.