Spectrum update #11
Draft
Spectrum update #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David Updates
Adding the hanning norm windows; S1 and S2.
removing predefined prefactor; dt ~ 1/fs
Changing the default window to hanning
Removed the unused pwr_2 variable and including the renormalized pwr variable and the pwr_den variable.
Adding pwr_den to the list of output variables.
…into spectrum_update
Collaborator
Author
|
The Hanning window and norm is correct. I have not implemented the other window-norms. Don't finish this pull. For some reason all the files Josh uploaded were removed. |
dschaffner
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue partially solves #10, in the sense it implements the correct normalization for the hanning windowing.
There are two alterations that change how spectrum_wind is used. First, there are 9 output variables; the new is the power spectral density variable. The second change corresponds to the prefactor in the previous version. The prefactor is not removed entirely the new normalization implements the prefactor in the power density.
** I believe the previous version pwr variable was the power spectral density and not the power spectrum.