Conversation
…lation section of the `compare_corr()` method in `BackgroundCatalog`. #70
… method of `BackgroundCatalog` were using `floats` instead of `ints`. #70
…og` to calculate the percent difference or percent error between two different correlation functions. #70
…os()` to only print if `vb` is set to `True` in `BackgroundCatalog`.
…` that computes the relative importance of each foreground galaxy in a given lightcone from 0 to 1. #66
…_importance()`. #66
…ized by the largest importance for each `lightcone`. #66
…ground objects with `importance` greater than the kwarg `importance_lim`, which by default is set to 0.0 (so all galaxies are used). #66
…the method is not making the lensing process noticably faster. #66
…ifference error. #70
…f treecorr is not installed.
…rposes, but reverted changes.
…poses, preparing for pull.
…s and definitions to be placed. The first script is called `lens_compare.py` which creates a `BackgroundCatalog`, lenses it by `WLMap`s and halos, and then compares the correlation of each.
… method in `BackgroundCatalog`.
…oundCatalog` to correctly calculate the strongly-lensed ellipticity if g>1. However, `lens_by_map()` currently removes all galaxies with a g>0.5. #58
Owner
|
I am amazed that this branch can be merged cleanly. @tcollett @charlottenosam what criteria would you like us to meet before merging all this weak lensing work into the Pangloss master branch? At the moment the basic Pangloss test does not work, because the data is not quite in the right place ( #11 ), but I am worried that when we merge in from the |
….py`, `plotting.py`, and the `lens_compare` test that I used in the final days of finishing my thesis. I must have forgotten one final push - oops! The only major changes were finishing the implementation of the log-likelihood calculation in `background`, pre-calculating the redshift bin volumes (implemented in `grid` and called in `background`) to speed up the smooth-component correction, and a few plotting changes in `plotting` for better plots to use in my thesis. I dont think this should conflict much (or at all) with what David has started to work on. Sorry for any confusion! #73 #101
Last few edits from Spencer
Issue 105 pipable
Touch Ups
…tching Issue 103 python data fetching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've started looking into reading in and using weak lensing data with Pangloss. We can use this pull request to track changes in the wl branch.