Skip to content

Simple Monte Carlo: First Attempt#112

Open
davidthomas5412 wants to merge 30 commits intodrphilmarshall:wlfrom
davidthomas5412:wl
Open

Simple Monte Carlo: First Attempt#112
davidthomas5412 wants to merge 30 commits intodrphilmarshall:wlfrom
davidthomas5412:wl

Conversation

@davidthomas5412
Copy link
Copy Markdown
Collaborator

@davidthomas5412 davidthomas5412 commented Nov 1, 2016

Resolves issues 103, 110, 111. Let's merge this before it gets any larger.

Testing:
Ran SimpleMonteCarlo.ipynb

@drphilmarshall
Copy link
Copy Markdown
Owner

Oof - a conflict in demos/ForegroundGalaxyOverlay.ipynb. Can you deal with that please? Probably you'll need to make a local copy, then pull from base, and then over-write the notebook with your local copy before committing. Thanks!

@drphilmarshall drphilmarshall self-assigned this Nov 2, 2016
@drphilmarshall
Copy link
Copy Markdown
Owner

Actually, it merged just fine locally. I'm working through the notebooks now, and will push my commits back soon (probably with some notebooks still failing - that's OK, I'll need to fix them in order to close the Travis issue #106 anyway).

@drphilmarshall drphilmarshall changed the title Latest sync Simple Monte Carlo: First Attempt Nov 2, 2016
@davidthomas5412
Copy link
Copy Markdown
Collaborator Author

davidthomas5412 commented Nov 7, 2016

The bugs highlighted in PR5 have been resolved. This is a good checkpoint for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants