fix chain id #167
Merged
fix chain id #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix the chain ID for Fraxtal's Holesky testnet from 2522 to 2523 in the autogenerated chain metadata file. However, this change creates a critical configuration mismatch.
Key Issue
- The
chains.yamlfile defines Fraxtal testnet with chain-id0x9da(2522 in decimal) - This PR changes
chains-meta.yamlto use chain-id 2523 - Since
chains-meta.yamlis autogenerated and must matchchains.yaml, this creates an inconsistency that could break the RPC system configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| symbol: frxETH | ||
| decimals: 18 | ||
| chain-id: 2522 | ||
| chain-id: 2523 |
There was a problem hiding this comment.
The chain ID is being changed from 2522 to 2523, but chains.yaml still has the Fraxtal testnet configured with chain-id: 0x9da (which is 2522 in decimal). This creates a mismatch between the two configuration files. If 2523 is the correct chain ID, then chains.yaml line 1682 should be updated to 0x9db (2523 in hex). If 2522 is correct, this change should not be made.
artemrootman
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.