This repository was archived by the owner on Mar 26, 2020. It is now read-only.
fix #298 #299
Open
fix #298 #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message from Dropbox CLA bot @konovalov-aleks, it looks like you've already signed the Dropbox CLA. Thanks! |
Contributor
|
Can you explain the shell magic here? Is this removing escape characters added by the Windows cmd.exe? As I mentioned in my comment on the issue here, I think it might not make sense to rely on proper arg passing from cmd to sh/bash, but instead write a bash script containing the args. if this fix is assuming that MINGW implies "args are coming from cmd.exe" then that seems like it might be overbroad. |
artwyman
suggested changes
Apr 9, 2019
Contributor
artwyman
left a comment
artwyman
left a comment
There was a problem hiding this comment.
Invoking the code review process here so the right status & ownership is marked, though I suspect this PR isn't likely to move further if it hasn't in so long.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.