canard: added buckets for the RX handler list #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-canard-rx-buckets
branch
from
3f9fce2 to
05af194
Compare
tridge
force-pushed
the
pr-canard-rx-buckets
branch
from
05af194 to
674149c
Compare
this reduces CPU cost at the expense of a little more memory
tridge
force-pushed
the
pr-canard-rx-buckets
branch
from
674149c to
3ec7556
Compare
tpwrules
reviewed
Jul 12, 2025
Collaborator
tpwrules
left a comment
tpwrules
left a comment
There was a problem hiding this comment.
Could have sworn I left a review.
Looks good to me. A couple places you could factor out the bucket computation and it should probably be made a (static inline) function. Might also be worth switching to a more even "hash".
I don't think it should be changed now, just thoughts for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this reduces CPU cost at the expense of a little more memory