main: set local node icon becomes hand #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
now I've pressed the "allow running tests" on this PR for you the CI will auto-build a windows binary for you. I could teach you how to setup a local build environment if you like, but for the windows build using CI is really easiest. For the linux build doing "python3 -m pip install ." is easiest |
Contributor
Author
|
@tridge, great, thanks very much! i'll give it a test and see how it looks. |
Contributor
Author
|
|
tridge
force-pushed
the
checkbox-to-hand
branch
from
09c9be1 to
56a1e36
Compare
Contributor
Author
|
I think we can merge this maybe? No huge rush of course |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the icon to the right of the "Set local node ID". Currently it is a checkbox but after this change it becomes a "hand" with the word "Set" to the right of it.
A checkbox is normally for turning an option on/off but in this case what we really want is more of a button. Using the "hand" icon is consistent with other pages like the "ESC MAnagement Panel"
I must admit that I haven't actually figured out how to build and run this change so it's untested but I still suspect the change works. If someone could give me a bit of advice on how to build and test I'd be overjoyed to test this important change :-)