fix: add missing adbutils dependency

[johnmalek312]

Fixes #1

The adbutils module is used throughout the codebase (in pidcat.py and tests) but was not listed in dependencies, causing installation errors.

Changes

• Added adbutils to dependencies in pyproject.toml
• Added adbutils to requirements.txt

Generated with Claude Code

[claude]

Code Review - PR #3: Add missing adbutils dependency

Summary

This PR correctly addresses issue #1 by adding the missing adbutils dependency to both pyproject.toml and requirements.txt. The dependency is indeed used throughout the codebase and was causing installation errors.

✅ Positive Findings

Correctness

• The dependency is legitimately required - confirmed usage in:
  • async_adbutils/pidcat.py:28 (import adbutils)
  • Multiple test files (tests/test_adb_server.py, test_real_device/*.py)
  • README examples showing adbutils imports
• Both files updated consistently (pyproject.toml and requirements.txt)
• Alphabetical ordering preserved in requirements.txt

Code Quality

• Clean, focused change - only adds what is needed
• Proper fix for the reported installation issue

🔍 Issues & Recommendations

1. Minor: Missing newline at end of requirements.txt

Location: requirements.txt:5

The file ends without a trailing newline. While this does not break functionality, it is a common convention to include it.

Recommendation: Add a newline after adbutils to follow POSIX text file conventions.

2. Question: Dependency Version Pinning

Context: All dependencies in pyproject.toml are unpinned (no version constraints).

Consideration: While unpinned dependencies allow flexibility, they can lead to:

• Breaking changes when upstream packages update
• Non-reproducible builds
• Potential compatibility issues

Recommendation (optional): Consider adding minimum version constraints if specific features or bug fixes are required, e.g., "adbutils>=0.11.0". This is not blocking for this PR but worth considering for the project dependency management strategy.

3. Question: Relationship with adbutils

Given that this is async_adbutils (an async fork of the synchronous adbutils), and the codebase imports the synchronous adbutils library:

• Is there a specific reason both libraries coexist?
• Is adbutils used for sync operations while async_adbutils provides async alternatives?
• Should this dependency relationship be documented?

This is more of a project architecture question than a PR issue.

🎯 Test Coverage

No new tests needed - this PR adds a missing dependency that enables existing functionality to work properly.

🔒 Security

No security concerns identified. Adding a legitimate required dependency.

⚡ Performance

No performance impact.

✅ Verdict

LGTM with minor suggestion - The PR correctly fixes the reported issue. The only actionable item is adding the trailing newline to requirements.txt to follow conventions, but this is not blocking.

---

Review performed by Claude Code