fix: install Python packages system-wide instead of virtualenv #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original Dockerfile used `pipenv install` which creates a virtual environment. However, the application is run with system Python, causing ModuleNotFoundError for privex-helpers and other dependencies. Generate lock file and use `--system --deploy` flags to install packages to the system Python, making them available when the app runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hypercorndependency (required byrun.sh prod)PIPENV_PYTHONto ensure correct Python version is used on AlpineProblem
The original
pipenv installcreates a virtual environment, but the application runs with system Python. This causes:Additionally,
hypercornwas missing from the Pipfile despite being required byrun.sh prod.Changes
ENV PIPENV_PYTHON=/usr/local/bin/python3.9to ensure pipenv uses the correct Pythonpipenv lock && pipenv install --system --deployto install packages system-widehypercorn = "*"to PipfileTest plan
./run.sh prod