01-Leap Year #20
Open
01-Leap Year #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mettizik
reviewed
Nov 2, 2018
Collaborator
mettizik
left a comment
mettizik
left a comment
There was a problem hiding this comment.
Всё отлично, немного не хватило рефакторинга в конце (это опционально в данном случае - на вкус и цвет), но обилие if'ов и return'ов усложняет функцию для сопровождения. От последнего ифа можно было спокойно избавиться переместив его условие в ретурн:
return isDivisable(year, 4);
| { | ||
| EXPECT_TRUE(IsLeapYear(g_fourHundred)); | ||
| EXPECT_TRUE(IsLeapYear(g_fourHundred * 2)); | ||
| EXPECT_TRUE(IsLeapYear(g_fourHundred * 3)); |
Collaborator
There was a problem hiding this comment.
Отличное дополнение теста 👍 (но название немного портит картину ))
| } | ||
|
|
||
| TEST(LeapYear, Test400) | ||
| TEST(LeapYear, TestDivisible400) |
Collaborator
There was a problem hiding this comment.
не хватает непосредственно ожидания - понятно, что он проверяет кратность 400, но непонятно что должно стать с таким числом - каково ожидаемое поведение
03 - Bank OCR
04 - Fake Weather Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.