Skip to content

refactor(design-system): remove deprecated DsSystemStatus component [AR-53409] #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmurawski-dn wants to merge 1 commit into
base: next
Choose a base branch
from
Open

refactor(design-system): remove deprecated DsSystemStatus component [AR-53409] #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/design-system/src/components/ds-drawer/ds-drawer.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import DsDrawer from './ds-drawer';
import { DsButton } from '../ds-button';
import { DsTextInput } from '../ds-text-input';
import { DsIcon } from '../ds-icon';
// TODO: Use DsStatusBadge instead.
import { DsSystemStatus } from '../ds-system-status';
import { DsStatusBadge } from '../ds-status-badge';
import styles from './ds-drawer.stories.module.scss';
import { DsTypography } from '../ds-typography';
import type { DsDrawerProps } from './ds-drawer.types';
Expand Down Expand Up @@ -82,7 +81,7 @@ export const Default: Story = {
<>
<DsDrawer.Header>
<DsDrawer.Title>
Default Drawer <DsSystemStatus status="healthy" label="Active" />
Default Drawer <DsStatusBadge status="active" label="Active" />
</DsDrawer.Title>
<div className={styles.headerActions}>
<button className={styles.expand} aria-label="Expand">
Expand Down Expand Up @@ -179,7 +178,7 @@ export const WithTabs: Story = {
<>
<DsDrawer.Header>
<DsDrawer.Title>
Drawer with Tabs <DsSystemStatus status="healthy" label="Active" />
Drawer with Tabs <DsStatusBadge status="active" label="Active" />
</DsDrawer.Title>
<div className={styles.headerActions}>
<button className={styles.expand} aria-label="Expand">
Expand Down
87 changes: 0 additions & 87 deletions packages/design-system/src/components/ds-system-status/ds-system-status.module.scss
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions packages/design-system/src/components/ds-system-status/ds-system-status.stories.ts
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions packages/design-system/src/components/ds-system-status/ds-system-status.tsx
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions packages/design-system/src/components/ds-system-status/ds-system-status.types.ts
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions packages/design-system/src/components/ds-system-status/index.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/design-system/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export * from './components/ds-smart-tabs';
export * from './components/ds-spinner';
export * from './components/ds-status-badge';
export * from './components/ds-stepper';
export * from './components/ds-system-status';
export * from './components/ds-table';
export * from './components/ds-tabs';
export * from './components/ds-tag';
Expand Down
2 changes: 1 addition & 1 deletion packages/design-system/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default defineConfig({
'**/ds-chip/**',
'**/ds-chip-group/**',
'**/ds-confirmation/**',
'**/ds-system-status/**',
'**/ds-date-input/**',
],
thresholds: {
lines: 90,
Expand Down
11 changes: 0 additions & 11 deletions packages/eslint-plugin/src/__tests__/no-deprecated.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,6 @@ ruleTester.run('no-deprecated-ds-confirmation', plugin.rules['no-deprecated-ds-c
],
});

ruleTester.run('no-deprecated-ds-system-status', plugin.rules['no-deprecated-ds-system-status'], {
valid: ['<DsStatusBadge />'],

invalid: [
{
code: '<DsSystemStatus />',
errors: [{ message: `DsSystemStatus is deprecated. Use DsStatusBadge instead.` }],
},
],
});

ruleTester.run(
'no-deprecated-ds-dropdown-menu-legacy',
plugin.rules['no-deprecated-ds-dropdown-menu-legacy'],
Expand Down
6 changes: 0 additions & 6 deletions packages/eslint-plugin/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@ const eslintPlugin = createPlugin(
message: `DsConfirmation is deprecated. Use DsModal instead.`,
},

{
name: 'no-deprecated-ds-system-status',
selector: JSXElement('DsSystemStatus'),
message: `DsSystemStatus is deprecated. Use DsStatusBadge instead.`,
},

{
name: 'no-deprecated-ds-dropdown-menu-legacy',
selector: JSXElement('DsDropdownMenuLegacy'),
Expand Down
Loading