Fix made for Table attribute being generated with the wrong arg name#489
Merged
Fix made for Table attribute being generated with the wrong arg name#489
Conversation
calebdw
approved these changes
Mar 24, 2026
peterfox
changed the title
|
please make this to release version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in TablePropertyToTableAttributeRector where it was using the incorrect argument name table instead of name for the Eloquent Table attribute. This aligns the Rector rule with the expected attribute structure in Laravel 13+ and the existing TableAttributeFactory.
Changes
• Rector Rule: Updated TablePropertyToTableAttributeRector to:
◦ Search for the name argument when checking existing Table attributes.
◦ Update getRuleDefinition code samples to use name: '...'.
• Tests: Updated all test fixtures in tests/Rector/Class_/TablePropertyToTableAttributeRector/Fixture to use name: '...' instead of table: '...' in the expected output (and input where applicable).
Context
Pointed out in #477
Incorrect argument name used. https://github.com/laravel/framework/blob/13.x/src/Illuminate/Database/Eloquent/Attributes/Table.php#L21