feat: add new RemoveDownMethodFromMigrations as an opt-in rule for removing the down method's of migration#487
Open
joshdonnell wants to merge 4 commits intodriftingly:mainfrom
Conversation
Collaborator
|
Thanks @joshdonnell . Is there much value in this over just publishing the stubs and then removing the down method from them compared to having a rule in place? |
Thank you for the reply, I believe there is initially what made me create the PR was my dev team members kept asking for something that would automatically remove the down methods for them as we where already using rector it made more sense than adding to Pint for example. I get that you can modify the stubs but I think having this in rector feels more aligned tooling wise for me personally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As someone who always removes the down() method, I felt this rule could be useful as an opt-in alternative to publishing custom migration stubs via Artisan — with the same end result.
It removes the down() method and its docblock comment from migration files.
Enable it by adding:
->withRules([ RemoveDownMethodFromMigrationsRector::class, ]);