support console scroll back to see and work with lines off the screen #360
+30
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
console contents are kept in a ring buffer currently MAX_CONSOLE_LINES = 500 with MAX_LINE_LENGTH = 128 characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console contents are kept in a ring buffer
currently MAX_CONSOLE_LINES = 500
with MAX_LINE_LENGTH = 128 characters
I would like to hear a suggestion for adding 'up' and 'down' keys to the on-screen keyboard!
Some notes:
If your mouse cursor is in the console box, you can scroll up and down with the mouse wheel
If you select a line in the console, you can scroll up and down with 'up' and 'down' arrows
This seems to work with FT8's line selection, even when scrolling back in time.
The 500 line ring buffer starts out "full" of empty lines. 500 lines was the old value (it was just the max console size I guess, with no way to change it - I do think I have seen large/tall consoles in the web interface that this would have enabled), I didnt change it. It is possible to scroll back in time, into the empty lines. I think this is ok and not worth extra code
Could definitely use some more users / real use / testing!