Split types into separate symbol table and type-level functions#1
Draft
krishnachittur wants to merge 4 commits intomainfrom
Draft
Split types into separate symbol table and type-level functions#1krishnachittur wants to merge 4 commits intomainfrom
krishnachittur wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors types in order to make future improvements/additions to typing either. In particular, we
TypeintoBaseTypeandResolvedType, which allow us to cleanly express type-level functions likelist,map, etc.map[string, list[Foo]]) to deduplicate typesIn the longer term this should also unblock work on generic user-defined types.
TODO (for this PR)
TODO after this PR
StructDeclparsing to mutate in place in the type symbol tableCat::meow, valuefn[...]) AND the type symbol table (as a mutation of e.g. theCatStructDecl)uses_selftoBaseType::Fnso that we can track those kinds of functions in the symbol tablecat.meow()could call a closure attribute, not just a method)BaseType