Skip to content

Repo cleanup and code housekeeping#11

Merged
drewburchfield merged 3 commits intomasterfrom
fix/repo-cleanup-and-housekeeping
Apr 3, 2026
Merged

Repo cleanup and code housekeeping#11
drewburchfield merged 3 commits intomasterfrom
fix/repo-cleanup-and-housekeeping

Conversation

@drewburchfield
Copy link
Copy Markdown
Owner

@drewburchfield drewburchfield commented Apr 3, 2026

Summary

  • Consolidate mypy.ini into pyproject.toml, remove requirements.txt (NAS-994)
  • Update Dockerfile: deps-only install from pyproject.toml, remove tests from image
  • Move diagnostic script to scripts/, config example to docs/
  • Remove stale references, fix type hints, update test fixtures (NAS-996)
  • Fix CHANGELOG: merge duplicate [Unreleased] sections, add recent PR notes
  • Remove vestigial HNSW env vars from docker-compose.yml and README

Fixes NAS-994, NAS-996

Test plan

  • All 133 unit tests pass
  • Lint (ruff) and format (black) clean
  • mypy passes with consolidated config
  • Docker build succeeds with new Dockerfile
  • Server starts and all 6 MCP tools pass E2E in Docker
  • tests/ directory not present in production image

Open with Devin

NAS-994: Repo structure cleanup
- Consolidate mypy.ini into pyproject.toml [tool.mypy]
- Remove requirements.txt, add dependencies to pyproject.toml
- Update Dockerfile to use pyproject.toml instead of requirements.txt
- Remove tests/ from production Docker image
- Move .obsidian-graph.conf.example to docs/
- Move diagnose_vault.py from src/ to scripts/
- Add .mypy_cache/ and .ruff_cache/ to .gitignore
- Remove vestigial HNSW env vars from docker-compose.yml
- Fix CHANGELOG: merge two [Unreleased] sections, add recent PR notes

NAS-996: Code housekeeping
- Remove oachatbot references from vector_store.py and indexer.py
- Fix type annotation: cause: Exception | None = None
- Remove deprecated event_loop fixture from conftest.py
- Use timezone-aware datetime.now(UTC) in test fixtures
- Fix test_refresh_lock to actually test lock serialization
- Dockerfile: install deps only (not package) to avoid PYTHONPATH conflict
- README: remove vestigial HNSW env var documentation
- conftest.py: update docstring (remove event_loop reference, fix project name)
- test_hub_analyzer: rewrite lock test to directly test serialization
CI workflow still referenced requirements.txt after it was removed.
Updated lint and test jobs to install deps from pyproject.toml.
@drewburchfield drewburchfield merged commit bef4dc0 into master Apr 3, 2026
4 checks passed
@drewburchfield drewburchfield deleted the fix/repo-cleanup-and-housekeeping branch April 3, 2026 19:32
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant