Skip to content

Patch 1 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mscharp wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Patch 1 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f108dd2
Update min.as
mscharp Mar 24, 2014
fb3adc7
Update MinTest.as
mscharp Mar 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions asx/src/asx/array/min.as
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ package asx.array
{
for each (item in iterable)
{
if (!result)
if (!result && !(result is Number))
{
result = item;
}
Expand All @@ -39,4 +39,4 @@ package asx.array

return result;
}
}
}
6 changes: 3 additions & 3 deletions asx_test/src/asx/array/MinTest.as
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ package asx.array
[Test]
public function min_withArray_returnsTheMinimumItem():void
{
assertThat(min([1, 101, 11, 10, 100]), equalTo(1));
assertThat(min(['1', '101', '11', '10', '100']), equalTo('1'));
assertThat(min([1, 101, 11, 10, 0, 100]), equalTo(0));
assertThat(min(['1', '101', '11', '10', '0', '100']), equalTo('0'));
}

[Test]
Expand All @@ -24,4 +24,4 @@ package asx.array
assertThat(min(items, 'value'), hasProperty('value', 1));
}
}
}
}