Optimize cache preview generation with fast FFmpeg seeks.#505
Open
dotrgle wants to merge 1 commit intodres-dev:masterfrom
Open
Optimize cache preview generation with fast FFmpeg seeks.#505dotrgle wants to merge 1 commit intodres-dev:masterfrom
dotrgle wants to merge 1 commit intodres-dev:masterfrom
Conversation
lucaro
requested changes
Dec 12, 2025
| .addArguments("-b:v", "2000k") | ||
| .addArguments("-filter:v", "scale=${this@CacheManager.config.cache.previewVideoMaxSize}:-1") | ||
| .addArguments("-tune", "zerolatency") | ||
| .addArguments("-preset", "slow") |
Collaborator
There was a problem hiding this comment.
This re-encoding is very deliberate to improve reliability when playing back the target sequences in the viewer. What was your reasoning to change this?
Collaborator
|
Thank you very much for this pull request. I have one question regarding a change, otherwise I'd be happy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizes media preview generation by implementing FFmpeg fast-seeking (-ss before input) to significantly reduce processing time for video segments and snapshots.