DX-59038 flightsql release jobs failing #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest tagged version of vcpkg Change-Id: Iea254b5f3cb257cc3e805f4086e619fd36d225d5
Update to latest tagged version of vcpkg Change-Id: Iea254b5f3cb257cc3e805f4086e619fd36d225d5
Add pkg-config to be installed by Brew
DremioQA
pushed a commit
that referenced
this pull request
Aug 23, 2024
Wasn't building so moving forward from here. (This was the commit being used by the release job prior to DX-90582. +Patched out vcpkg.json builtin-baseline in an attempt to work around vcpkg & VS2022 incompatibility, as detailed from roughly microsoft/vcpkg#22074 (comment) onward. Overall it appears the issue is an out-of-date vcpkg binary, which by design cannot be updated (notwithstanding the linked comment...) without updating vcpkg package repo and therefore all dependency packages--so we are proceeding with that and hopefully Warpdrive builds with updated vcpkg packages. Change-Id: Ic7289452f69f046dcb8ccab3dbc4b31e90b9e1ab
jbonofre
approved these changes
Jan 14, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest tagged version of vcpkg