-
Notifications
You must be signed in to change notification settings - Fork 7
Bump nokogiri from 1.16.7 to 1.18.3 #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.7 to 1.18.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.18.3/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.16.7...v1.18.3) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
WalkthroughThe Gemfile was modified to update the version requirements for the "nokogiri" and "pry" gems, increasing their minimum allowed versions. No other dependencies or files were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Gemfile (1)
45-45: Keeppryout of production gemsWhile the version bump to
pry0.15 is harmless, the gem is still declared at top level, meaning it will be loaded in production bundles unless explicitly pruned. Shipping an interactive REPL in production increases attack surface and memory footprint. Consider moving it (and friends likepry-byebug,pry-rails) intogroup :development, :test.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Gemfile.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Gemfile(1 hunks)
🔇 Additional comments (1)
Gemfile (1)
43-43: Ensure Ruby ≥ 3.1 Before Upgrading to Nokogiri 1.18We ran checks and didn’t find any
.ruby-version,.tool-versions, orruby "x.y"directive in your Gemfile/Gemfile.lock. Without an explicit minimum Ruby version, CI or production environments still on Ruby 3.0 will fail to install Nokogiri 1.18.Please:
Verify that all runtimes (CI, staging, production, Heroku buildpacks, etc.) are using Ruby 3.1 or newer.
Consider enforcing the requirement by adding to your Gemfile:
ruby ">= 3.1"
Bumps nokogiri from 1.16.7 to 1.18.3.
Release notes
Sourced from nokogiri's releases.
... (truncated)
Changelog
Sourced from nokogiri's changelog.
... (truncated)
Commits
fd3ca2eversion bump to v1.18.3a8c526adep: update libxml2 to v2.13.6 (#3437)0847cf8ci: tired of waiting for gnome mirrors11945c8dep: update libxml2 to v2.13.6aa54fa5version bump to v1.18.20fb5541backport: fix(css-selector): default XML namespace should not be applied to w...8ef2e91ci: bump windows test images from "head" to "3.4"c10fd7adev: so tired of psych not building on various things8378749fix(css-selector): default XML namespace is not applied to wildcardb112e18prefactor: restructure css-to-xpath testsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit