Skip to content

Conversation

@daem-on
Copy link

@daem-on daem-on commented Mar 26, 2021

It's not much, but I think it's an improvement, main things are changes to the layout, most things are sized adapting to the viewport size, also changed the font to Lato, but it can be anything else I just like this font (and it's free).

Had to merge the new changes in midway through, so some of that is a little rough, would like to work on it more though, please tell me what you think.

Also this could probably use some colors, I didn't change anything about the white-black color scheme.

@drcursor
Copy link
Owner

Hi @daem-on , I merged #1 a few minutes ago/before your submission. Can you base your changes off the current files ?

@daem-on
Copy link
Author

daem-on commented Mar 26, 2021

Hi @daem-on , I merged #1 a few minutes ago/before your submission. Can you base your changes off the current files ?

Well, I don't think it would make sense to base off the other one, I mostly changed the same things as @kirrus, so you should see which one you prefer.

The main difference is that my version uses vanilla css and no dependencies, as opposed to the merged one which uses bootstrap. I set the layout and scaling of the elements by hand, so it works a bit better than bootstrap's automatic layout.

So yeah, if you prefer the bootstrap version, my changes won't be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants