chore: upgrade to PHPUnit 11 and 12 #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In https://github.com/dragonmantank/cron-expression/pull/207/files , you lowered the phpstan level from max to 2. Was that on purpose? Maybe this PR should restore it xor I think a ticket should be made to increase the level again. :) |
Author
|
Yes this was on purpose. |
Owner
|
I agree. Let's get PHPUnit updated, and then we can work on phpstan stuff as a second item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove phpstan/phpstan 1 (not longer needed with PHP bump)
the
-voption does not longer exists in the phpunit clii did not remove the tests for < PHP 8.1
Maybe someone wants to rewrite the tests in the future