Big refactor to use coroutines across the codebase by ryan-rushton · Pull Request #106 · dprint/dprint-intellij

ryan-rushton · 2025-05-11T05:49:41Z

Overview

This is a big refactor to simplify the codebase and utilise coroutines opposed to threads, processes, futures and callbacks.

It also adds a lot of tests that were previously missing.

.claude/settings.local.json

src/main/kotlin/com/dprint/formatter/DprintFormattingTask.kt

CLAUDE.md

src/main/kotlin/com/dprint/services/editorservice/EditorServiceCache.kt

src/main/kotlin/com/dprint/services/editorservice/EditorServiceTaskQueue.kt

src/main/kotlin/com/dprint/services/editorservice/v5/EditorServiceV5.kt

src/test/kotlin/com/dprint/services/editorservice/EditorServiceCacheTest.kt

src/test/kotlin/com/dprint/services/editorservice/EditorServiceFormatterTest.kt

src/main/kotlin/com/dprint/services/editorservice/EditorServiceCache.kt

src/test/kotlin/com/dprint/services/editorservice/EditorServiceCacheTest.kt

src/test/kotlin/com/dprint/services/editorservice/EditorServiceFormatterTest.kt

src/main/kotlin/com/dprint/services/DprintService.kt

ryan-rushton · 2025-06-23T22:51:52Z

src/main/kotlin/com/dprint/services/DprintService.kt

+        if (isInitialized.get() || isRestarting.get()) {
+            return // Already initialized or in progress
+        }


Probably don't want this. The queue should ensure that duplicated tasks are not queued. I need to review this manually.

CHANGELOG.md

ryan-rushton · 2025-06-26T13:15:37Z

src/main/kotlin/com/dprint/formatter/DprintRangeFormattingTask.kt

+        // In most cases for typical code files, byte offset == character index
+        // But for files with multi-byte characters, we need proper conversion
+        return minOf(byteOffset, text.length)


This isn't correct

Add progress Actually make it work with claude fmt Update docs and clenaup unused methods Add tests and some other updates More updates fmt Update lowst IJ version Update listeners to coroutines More cleanup and fix issue with tasks not being removed from the queue Add tests for success cleanup Move to coroutines for the process Method rename Logging Set beta version Cleanup formatter service. Replace pending messages with message channel Cleanup Remove formatter service callbacks Clean up future usage in formatting task Cleanup error name fmt Set up persisted state abstraction Split up editor service Apply suggestions from code review fix Move null service handling to manager Some cleanup Formatting Fix issue with cache prime failing due to inistialisation not being finished yet. Fix buffer issue version bump Fix some cache timing issues Simplify Apply suggestions from code review Cleanup dprint service a bit doc changes Update CHANGELOG.md Update CHANGELOG.md Bump beta version Remove range formatting More range cleanup Add back range stuff More reimplmenting the range buisness Some error handling Fix up git ignore Cleanup verbose errors Cleanup incorrect conversion Improve config file discovery Add reset settings button Update i18n Add lifecycle manager Add tool window icons

ryan-rushton force-pushed the 2025-updates-remove-background-task-queue branch from fd6013e to b6bb5c5 Compare June 21, 2025 01:17