Skip to content

adding new MDL institutions#656

Merged
mdellabitta merged 1 commit intomainfrom
MDL-opt-in
Dec 13, 2025
Merged

adding new MDL institutions#656
mdellabitta merged 1 commit intomainfrom
MDL-opt-in

Conversation

@DominicBM
Copy link
Contributor

@DominicBM DominicBM commented Dec 12, 2025

several new participating institutions

Summary by CodeRabbit

  • Chores
    • Updated the institutions database by adding Wikidata identifiers to enhance institutional recognition and improve linking across the system.
    • Synchronized upload status for multiple institutions, enabling active data exchange capabilities for recognized institutions.
    • Enriched institutional metadata with additional collection and reference details for improved organization tracking.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2025

Walkthrough

This PR updates src/main/resources/wiki/institutions_v2.json with modifications to institution metadata. Multiple entries receive updated Wikidata identifiers and toggled upload flags, transitioning certain institutions from inactive to active states within the data structure.

Changes

Cohort / File(s) Summary
Institution metadata updates
src/main/resources/wiki/institutions_v2.json
Updates Wikidata identifiers and upload boolean flags for multiple institution entries; some entries transition from inactive (upload: false) to active (upload: true) with corresponding Wikidata IDs assigned; adds or expands entries with detailed sub-entry notes and URL references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify Wikidata IDs are correct and valid
  • Confirm upload flag changes are intentional and correctly paired with Wikidata assignments
  • Check for any unintended side effects on institution matching logic downstream

Possibly related PRs

Suggested reviewers

  • mdellabitta

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'adding new MDL institutions' is directly related to the main change, which adds and activates multiple new institution entries in the institutions_v2.json file with Wikidata IDs and upload flags set to true.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch MDL-opt-in

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30e22c1 and c4f926e.

📒 Files selected for processing (1)
  • src/main/resources/wiki/institutions_v2.json (5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (5)
src/main/resources/wiki/institutions_v2.json (5)

26715-26718: Please double-check the Wikidata ID + activation toggle for this institution.
Switching "upload" to true will change ingestion behavior; worth validating that Q5146820 is the correct entity for “College of Saint Benedict & Saint John's University” (and not a similarly-named org).


26831-26834: Verify Q124695687 maps to the exact “Grant County Historical Society” you intend.
Given the generic name, it’s easy to accidentally link the wrong county/state org; enabling "upload": true makes this high-impact if mislinked.


27039-27042: Confirm Q137371899 is the correct Wikidata entity for “Minnesota Legislative Reference Library”.
If downstream matching uses both name + QID, mismatches here can be subtle; worth validating before merging.


27147-27150: Validate Q6868559 corresponds to “Northwest Minnesota Historical Center” before enabling uploads.
This is the kind of entry where an incorrect QID won’t break JSON but will misattribute data.


27391-27430: This concern is incorrect. The institutions JSON file uses institution name (not Wikidata ID) as the lookup key for enrichment. Multiple institutions can legitimately share the same parent organization Wikidata ID—e.g., "University of Minnesota Libraries" and its specialized branches (Immigration History Research Center Archives, etc.) all map to Q7895799 by design. Each institution name is a separate lookup entry in WikiEntityEnrichment.scala, so no collision or deduplication occurs. The file structure and code handling support this pattern appropriately.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mdellabitta mdellabitta self-requested a review December 13, 2025 15:30
@mdellabitta mdellabitta merged commit 4d7123f into main Dec 13, 2025
6 checks passed
@mdellabitta mdellabitta deleted the MDL-opt-in branch December 13, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants