Skip to content

made it so you can turn off psql cert validation locally#88

Merged
mdellabitta merged 1 commit intomainfrom
local-leinent-ssl
Feb 27, 2025
Merged

made it so you can turn off psql cert validation locally#88
mdellabitta merged 1 commit intomainfrom
local-leinent-ssl

Conversation

@mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Feb 27, 2025

Important

Enable local override of PostgreSQL SSL settings in application.conf using environment variables.

  • Configuration:
    • In application.conf, PostgreSQL SSL settings can now be overridden by environment variables SSL, SSL_MODE, and SSL_FACTORY.
    • Allows disabling SSL certificate validation locally by setting these environment variables.

This description was created by Ellipsis for 300792f. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 300792f in 1 minute and 24 seconds

More details
  • Looked at 16 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 drafted comments based on config settings.
1. src/main/resources/application.conf:42
  • Draft comment:
    Duplicate assignment for 'ssl'. Ensure fallback order is intentional.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
2. src/main/resources/application.conf:44
  • Draft comment:
    Duplicate 'sslmode' assignment. Verify that environment variable SSL_MODE is provided when needed.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
3. src/main/resources/application.conf:46
  • Draft comment:
    Duplicate 'sslfactory' assignment. Ensure SSL_FACTORY env var, if set, supplies a valid implementation.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
4. src/main/resources/application.conf:43
  • Draft comment:
    Ensure the SSL override via env var is clearly documented. Verify that if SSL env var is unset, the default 'true' remains in effect.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
5. src/main/resources/application.conf:45
  • Draft comment:
    Confirm that overriding sslmode (default 'verify-full') via SSL_MODE is intended, and ensure it isn’t used inadvertently in production.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
6. src/main/resources/application.conf:47
  • Draft comment:
    Validate that providing an override for sslfactory via SSL_FACTORY is necessary and well documented.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
7. src/main/resources/application.conf:35
  • Draft comment:
    Typographical error: It appears that the key 'postNumber' on line 35 is a typo and should be 'portNumber' to be consistent with the intended configuration property.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_XD2D50IKE5r2L3DK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mdellabitta mdellabitta merged commit ab51a87 into main Feb 27, 2025
2 checks passed
@mdellabitta mdellabitta deleted the local-leinent-ssl branch February 27, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant