Skip to content

added ignore_missing flag to sentry release generation#84

Merged
mdellabitta merged 1 commit intomainfrom
sentry-release-fix
Dec 21, 2024
Merged

added ignore_missing flag to sentry release generation#84
mdellabitta merged 1 commit intomainfrom
sentry-release-fix

Conversation

@mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Dec 20, 2024

Important

Add ignore_missing: true to Sentry release creation in deployment workflows to handle missing commits.

  • Workflows:
    • Added ignore_missing: true to Sentry release creation in deploy-staging.yml and deploy.yml to prevent failures due to missing commits.

This description was created by Ellipsis for 18527c9. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 18527c9 in 8 seconds

More details
  • Looked at 25 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/deploy-staging.yml:65
  • Draft comment:
    Ensure that the ignore_missing: true flag in the Sentry release step is intended, as it will ignore missing commits when creating a release. This is also applicable in the deploy.yml file.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of the ignore_missing: true flag in the Sentry release step is consistent across both workflows. This flag is used to ignore missing commits when creating a release in Sentry. It is important to ensure that this behavior is intended and does not mask any potential issues with missing commits.

Workflow ID: wflow_70Yyk2f8mQsBuNan


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ebcdbb2) 2369 1962 82.82%
Head commit (18527c9) 2369 (+0) 1962 (+0) 82.82% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#84) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@mdellabitta mdellabitta merged commit c180592 into main Dec 21, 2024
5 checks passed
@mdellabitta mdellabitta deleted the sentry-release-fix branch December 21, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant