Skip to content

fixes to deployment workflows#80

Merged
mdellabitta merged 5 commits intomainfrom
fix-deployments
Dec 20, 2024
Merged

fixes to deployment workflows#80
mdellabitta merged 5 commits intomainfrom
fix-deployments

Conversation

@mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Dec 20, 2024

Important

Update deployment workflows to latest GitHub Actions versions and add Sentry release creation for staging and production.

  • Actions Version Updates:
    • Update actions/checkout to v4 in deploy-staging.yml and deploy.yml.
    • Update aws-actions/configure-aws-credentials to specific commit in deploy-staging.yml and deploy.yml.
    • Update aws-actions/amazon-ecr-login to specific commit in deploy-staging.yml and deploy.yml.
    • Update actions/setup-java to v4 in deploy-staging.yml and deploy.yml.
  • Sentry Integration:
    • Add Create Sentry release step in deploy-staging.yml for staging.
    • Add Create Sentry release step in deploy.yml for production.

This description was created by Ellipsis for ecccf05. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 42cf73a in 19 seconds

More details
  • Looked at 100 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/deploy.yml:17
  • Draft comment:
    The AWS credentials action version is inconsistent with the staging workflow. Consider updating to aws-actions/configure-aws-credentials@v4 for consistency.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The AWS credentials action version is inconsistent between the two workflows.

Workflow ID: wflow_bnLp3326szPDHZvn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@codacy-production
Copy link

codacy-production bot commented Dec 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f7f734b) 2369 1962 82.82%
Head commit (ecccf05) 2369 (+0) 1962 (+0) 82.82% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#80) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 4741608 in 50 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/deploy-staging.yml:59
  • Draft comment:
    The getsentry/action-release action is using a specific commit hash instead of @v1 as mentioned in the PR description. Consider using @v1 for consistency and to ensure you receive updates.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    This is a dependency version change. The rules explicitly state "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." Using a specific commit hash is often a deliberate choice for stability and security. The author likely had a good reason to pin to a specific commit.
    Maybe pinning to a specific commit could cause issues if there are critical security updates in the action. The comment could be raising a valid maintainability concern.
    While that's true, the rules are clear about not commenting on dependency changes. Additionally, pinning to specific commits is a common and valid practice for GitHub Actions to ensure reproducible builds.
    The comment should be deleted as it violates the rule about not commenting on dependency changes.
2. .github/workflows/deploy.yml:60
  • Draft comment:
    The getsentry/action-release action is using a specific commit hash instead of @v1 as mentioned in the PR description. Consider using @v1 for consistency and to ensure you receive updates.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_9DwodbFuhGU1jiuJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 44613f3 in 35 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/deploy-staging.yml:24
  • Draft comment:
    Consider using a version tag like v2 for aws-actions/amazon-ecr-login instead of a specific SHA to align with the PR description and improve maintainability.
  • Reason this comment was not posted:
    Marked as duplicate.
2. .github/workflows/deploy.yml:25
  • Draft comment:
    Consider using a version tag like v2 for aws-actions/amazon-ecr-login instead of a specific SHA to align with the PR description and improve maintainability. This issue is also present in deploy-staging.yml.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_MbWqUTXDC0Bx2WFe


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on ecccf05 in 31 seconds

More details
  • Looked at 41 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_dcqzrkuTCRnIjxKy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mdellabitta mdellabitta merged commit e304fc3 into main Dec 20, 2024
5 checks passed
@mdellabitta mdellabitta deleted the fix-deployments branch December 20, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant