Skip to content

Conversation

@vincent-gao
Copy link
Contributor

Jira

https://digital-vic.atlassian.net/browse/SD-1327

Problem/Motivation

Approvers are able to clone content in the same way that editors can clone content

Copy link
Contributor

@MdNadimHossain MdNadimHossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, but just a note, this will not get set on a fresh install.

Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need an update to config/install as well?

@vincent-gao
Copy link
Contributor Author

hi @MdNadimHossain / @anthony-malkoun
Short answer: no need.
This is a bit tricky. The approver role is defined by tide_core, and so, it doesn't have the ability to edit any content. This is because tide_core has no dependency on other sub-modules or custom modules, rather, they depend on tide_core. so ,theoretically, the content that can be edited is determined by the specific project. Unless we restructure the modules to allow tide_core to be aware of the available content types.

@vincent-gao vincent-gao merged commit d29e778 into develop Dec 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants