-
Notifications
You must be signed in to change notification settings - Fork 14
[SD-1287] - Added self service map component #1647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/2.47.0
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ripple-docs canceled.
|
ripple-framework
|
||||||||||||||||||||||||||||
| Project |
ripple-framework
|
| Branch Review |
feature/SD-1287-self-service-map
|
| Run status |
|
| Run duration | 14m 15s |
| Commit |
|
| Committer | David Featherston |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
4
|
|
|
0
|
|
|
0
|
|
|
285
|
| View all changes introduced in this branch ↗︎ | |
dylankelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See QA feedback from Tim https://digital-vic.atlassian.net/browse/SD-1287?focusedCommentId=499730
@jeffdowdle idk if you can knock that off today, else I will get @lambry to have a look.
packages/ripple-tide-search/components/TideSelfServiceMapAddress.vue
Outdated
Show resolved
Hide resolved
...es/ripple-tide-search/components/global/TideSelfServiceMap/TideSelfServiceMapContactCell.vue
Outdated
Show resolved
Hide resolved
@dylankelly thanks, i've updated those and will update the QA env for tim to retest |
Issue: https://digital-vic.atlassian.net/browse/SD-1287
What I did
How to test
Checklist
For all PR's
For new UI components only
emitRplEvent