Skip to content

Conversation

@jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-1287

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@jeffdowdle jeffdowdle added this to the 2.47.0 milestone Dec 15, 2025
@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit c265690
🔍 Latest deploy log https://app.netlify.com/projects/ripple-docs/deploys/694a199c564c460008350ffb

@cypress
Copy link

cypress bot commented Dec 16, 2025

ripple-framework    Run #3124

Run Properties:  status check passed Passed #3124  •  git commit c26569031c: fix(@dpc-sdp/ripple-ui-maps): hopefully fix production build issues in external ...
Project ripple-framework
Branch Review feature/SD-1287-self-service-map
Run status status check passed Passed #3124
Run duration 14m 15s
Commit git commit c26569031c: fix(@dpc-sdp/ripple-ui-maps): hopefully fix production build issues in external ...
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 285
View all changes introduced in this branch ↗︎

@jeffdowdle jeffdowdle changed the title feat(@dpc-sdp/ripple-tide-search): added self service map component [SD-1287] - Added self service map component Dec 16, 2025
Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See QA feedback from Tim https://digital-vic.atlassian.net/browse/SD-1287?focusedCommentId=499730

@jeffdowdle idk if you can knock that off today, else I will get @lambry to have a look.

@jeffdowdle
Copy link
Contributor Author

See QA feedback from Tim https://digital-vic.atlassian.net/browse/SD-1287?focusedCommentId=499730

@jeffdowdle idk if you can knock that off today, else I will get @lambry to have a look.

@dylankelly thanks, i've updated those and will update the QA env for tim to retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants