[SD-1251] Minimal upgrade to nuxt 4 #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ripple-docs canceled.
|
ripple-framework
|
||||||||||||||||||||||||||||
| Project |
ripple-framework
|
| Branch Review |
2.46.0-alpha.2
|
| Run status |
|
| Run duration | 14m 43s |
| Commit |
|
| Committer | Jason Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
281
|
| View all changes introduced in this branch ↗︎ | |
dylankelly
reviewed
Dec 8, 2025
dylankelly
approved these changes
Dec 8, 2025
waitingallday
commented
Dec 8, 2025
| } | ||
|
|
||
| if (process.client) { | ||
| if (import.meta.client) { |
Member
Author
There was a problem hiding this comment.
Nuxt 4 is moving to import.meta https://nuxt.com/docs/4.x/api/advanced/import-meta
waitingallday
commented
Dec 8, 2025
| supportFile: false, | ||
| downloadsFolder: './test/downloads', | ||
| fixturesFolder: './test/fixtures', | ||
| numTestsKeptInMemory: 10, |
Member
Author
There was a problem hiding this comment.
This prevents cypress open from exhausting its memory (defaults to 50 - cypress run always runs as 0)
waitingallday
commented
Dec 9, 2025
| @@ -0,0 +1,6 @@ | |||
| /// <reference types="parse-path" /> | |||
Member
Author
There was a problem hiding this comment.
parse-path is used by Lerna - the current version is missing a types def in the package that causes a build failure IonicaBizau/parse-path#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-1251
Rework of #1633 to maintain compatibility for nuxt 3 apps (hopefully)
What I did
How to test
Checklist
For all PR's
For new UI components only
emitRplEvent