Skip to content

Conversation

@dylankelly
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@netlify
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit f00cbfb
🔍 Latest deploy log https://app.netlify.com/projects/ripple-docs/deploys/6854ebc3aab3d10008540f18

@cypress
Copy link

cypress bot commented Jun 20, 2025

ripple-framework    Run #2883

Run Properties:  status check failed Failed #2883  •  git commit f00cbfb9b4: feat(@dpc-sdp/ripple-tide-api): rewrite iframe src to use embed page
Project ripple-framework
Branch Review feature/nuxt-scripts
Run status status check failed Failed #2883
Run duration 14m 33s
Commit git commit f00cbfb9b4: feat(@dpc-sdp/ripple-tide-api): rewrite iframe src to use embed page
Committer Dylan Kelly
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 257
View all changes introduced in this branch ↗︎

Tests for review

Failed  landingpage/openforms.feature • 1 failed test

View Output

Test Artifacts
Openforms > Renders form Test Replay Screenshots
Failed  maps/maps.feature • 1 failed test

View Output

Test Artifacts
Custom collection map component > Map can be viewed fullscreen Test Replay Screenshots
Failed  site/theme.feature • 1 failed test

View Output

Test Artifacts
Site theme > Favicon and app icons are set correctly Test Replay Screenshots
Flakiness  test/features/maps/vsba.feature • 2 flaky tests

View Output

Test Artifacts
School buildings map > On load Test Replay Screenshots
School buildings map > Search for postcode Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants