[SD-1247] Fix branch sync #401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Branch sync (6.x -> 7.x) workflows were failing silently which was blocking updates (such as bumping base image versions) to the 7.x branch.
This approach inverts the previous process and relies on the internal machinations of GitHub's PR creation process to determine the status of the PR.
Switching the processing of the diff of the merge to GitHub and the github-cli tool offloads the logic for handling of the diff output to GitHub in an attempt to improve consistency and time to remediation.
Changes
This simplifies the generation of the diffs with the same result as initially intended. The previous change to the cherry-pick/merge strategy resulted in changes being lost.
Testing
GHA job https://github.com/dpc-sdp/bay/actions/runs/19446890092
Resulting PR #391