fix: Blocked time release metrics are incorrect #279#305
Open
YuliaMittova wants to merge 1 commit intotoloka-agent/159-autofrom
Open
fix: Blocked time release metrics are incorrect #279#305YuliaMittova wants to merge 1 commit intotoloka-agent/159-autofrom
YuliaMittova wants to merge 1 commit intotoloka-agent/159-autofrom
Conversation
FAIL_TO_PASS: ReleaseMetricsIntegrationTests#shouldCorrectlyCalculateTotalBlockedDaysWhenNoFeatureIsBlocked, ReleaseMetricsIntegrationTests#shouldCorrectlyCalculateBlockedPercentageOfTimeWhenNoFeatureIsBlocked, ReleaseMetricsIntegrationTests#shouldCorrectlyCalculateTotalBlockedDaysForOneBlockedFeature, ReleaseMetricsIntegrationTests#shouldCorrectlyCalculateBlockedPercentageOfTimeForOneBlockedFeature, ReleaseMetricsIntegrationTests#shouldCorrectlyCalculateTotalBlockedDaysForSeveralBlockedFeature, ReleaseMetricsIntegrationTests#shouldCorrectlyCalculateBlockedPercentageOfTimeForSeveralBlockedFeature
YuliaMittova
force-pushed
the
bugfix/279-blocked-time-release-metrics-are-incorrect
branch
from
84962e7 to
00c17ff
Compare
innokenty
reviewed
Mar 31, 2026
| .mapToInt(f -> (int) (ChronoUnit.DAYS.between(f.getCreatedAt(), Instant.now()))) | ||
| .sum(); | ||
|
|
||
| int totalBlockedDays = blockedFeatures.size() * 5; // Simplified calculation |
There was a problem hiding this comment.
Lol, I just love how AI produced "Simplified calculations" 😂
innokenty
approved these changes
Mar 31, 2026
innokenty
reviewed
Apr 1, 2026
| .mapToInt(f -> (int) (ChronoUnit.DAYS.between(f.getUpdatedAt(), Instant.now()))) | ||
| .sum(); | ||
| final int totalDaysSinceCreated = features.stream() | ||
| .mapToInt(f -> (int) (ChronoUnit.DAYS.between(f.getCreatedAt(), Instant.now()))) |
There was a problem hiding this comment.
According to comment from @ElizavetaP , I think we just need to change this line here:
Suggested change
| .mapToInt(f -> (int) (ChronoUnit.DAYS.between(f.getCreatedAt(), Instant.now()))) | |
| .mapToInt(f -> (int) (ChronoUnit.DAYS.between(f.getCreatedAt(), f.getPlanningStatus() == FeaturePlanningStatus.DONE ? f.getUpdatedAt() : Instant.now()))) |
innokenty
requested changes
Apr 1, 2026
innokenty
left a comment
innokenty
left a comment
There was a problem hiding this comment.
Please address the discussion on the issue:
- adjust calculation logic (suggestion provided)
- adjust tests accordingly
- replace "in between" assertions with proper value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for issue #279