fix: release update notification error handling #292#304
Open
codecharlan wants to merge 1 commit intotoloka-agent/139-autofrom
Open
fix: release update notification error handling #292#304codecharlan wants to merge 1 commit intotoloka-agent/139-autofrom
codecharlan wants to merge 1 commit intotoloka-agent/139-autofrom
Conversation
ElizavetaP
requested changes
Mar 30, 2026
src/test/java/com/sivalabs/ft/features/domain/ReleaseServiceTest.java
Outdated
Show resolved
Hide resolved
...java/com/sivalabs/ft/features/api/controllers/ReleaseCascadeNotificationIntegrationTest.java
Show resolved
Hide resolved
...java/com/sivalabs/ft/features/api/controllers/ReleaseCascadeNotificationIntegrationTest.java
Outdated
Show resolved
Hide resolved
codecharlan
force-pushed
the
bugfix/292-release-update-notification-error-handling
branch
from
90fb659 to
2775489
Compare
ElizavetaP
requested changes
Apr 1, 2026
...java/com/sivalabs/ft/features/api/controllers/ReleaseCascadeNotificationIntegrationTest.java
Show resolved
Hide resolved
src/test/java/com/sivalabs/ft/features/domain/ReleaseServiceTest.java
Outdated
Show resolved
Hide resolved
...java/com/sivalabs/ft/features/api/controllers/ReleaseCascadeNotificationIntegrationTest.java
Show resolved
Hide resolved
codecharlan
force-pushed
the
bugfix/292-release-update-notification-error-handling
branch
from
2775489 to
98c51f8
Compare
ElizavetaP
requested changes
Apr 1, 2026
| new UpdateReleaseCommand("IDEA-1.0", "desc", ReleaseStatus.RELEASED, null, "manager"); | ||
|
|
||
| // When / Then - the exception must propagate so @Transactional can roll back | ||
| assertThatThrownBy(() -> releaseService.updateRelease(cmd)).isInstanceOf(RuntimeException.class); |
There was a problem hiding this comment.
Checking specifically for RuntimeException is too implementation-specific here. The important part is that the error is not swallowed and the update fails. Another valid fix could propagate a different exception type and still be correct, so it would be better to assert only that the call throws.
for example assertThatThrownBy(() -> releaseService.updateRelease(cmd));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix for #292
FAIL_TO_PASS: ReleaseServiceTest