Skip to content

fix: update release endpoint fails with 500 for non-existent release #289 #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codecharlan wants to merge 1 commit into
base: toloka-agent/123-auto
Choose a base branch
from
Open

fix: update release endpoint fails with 500 for non-existent release #289 #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/sivalabs/ft/features/domain/ReleaseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ public String createRelease(CreateReleaseCommand cmd) {

@Transactional
public void updateRelease(UpdateReleaseCommand cmd) {
Release release = releaseRepository.findByCode(cmd.code()).orElseThrow();
Release release = releaseRepository
.findByCode(cmd.code())
.orElseThrow(() -> new ResourceNotFoundException("Release with code " + cmd.code() + " not found"));
release.setDescription(cmd.description());
release.setStatus(cmd.status());
release.setReleasedAt(cmd.releasedAt());
Expand Down
19 changes: 19 additions & 0 deletions src/test/java/com/sivalabs/ft/features/api/controllers/ReleaseControllerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,25 @@ void shouldUpdateReleasePlanningFields() {
});
}

@Test
@WithMockOAuth2User(username = "user")
void shouldReturn404WhenUpdatingNonExistentRelease() {
var payload =
"""
{
"description": "Updated description",
"status": "IN_PROGRESS"
}
""";

var result = mvc.put()
.uri("/api/releases/{code}", "NONEXISTENT-CODE")
.contentType(MediaType.APPLICATION_JSON)
.content(payload)
.exchange();
assertThat(result).hasStatus(HttpStatus.NOT_FOUND);
}

@Test
@WithMockOAuth2User(username = "user")
void shouldDeleteRelease() {
Expand Down
Loading