Skip to content

fix: planning history endpoints require authentication and USER role #262 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codecharlan wants to merge 1 commit into
base: toloka-agent/128-auto
Choose a base branch
from
Open

fix: planning history endpoints require authentication and USER role #262 #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/com/sivalabs/ft/features/config/SecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,18 @@ SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception {
.permitAll()
.requestMatchers(HttpMethod.GET, "/api/products/**")
.permitAll()
.requestMatchers(
HttpMethod.GET,
"/api/features/*/history",
"/api/releases/*/history",
"/api/planning-history/**")
.hasRole("USER")
.requestMatchers(HttpMethod.GET, "/api/releases/**")
.permitAll()
.requestMatchers(HttpMethod.GET, "/api/features/**")
.permitAll()
.requestMatchers(HttpMethod.GET, "/api/comments/**")
.permitAll()
.requestMatchers(HttpMethod.GET, "/api/planning-history/**")
.permitAll()
.anyRequest()
.authenticated())
.sessionManagement(c -> c.sessionCreationPolicy(SessionCreationPolicy.STATELESS))
Expand Down
90 changes: 90 additions & 0 deletions src/test/java/com/sivalabs/ft/features/api/controllers/PlanningHistoryControllerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
class PlanningHistoryControllerTests extends AbstractIT {

@Test
@WithMockOAuth2User(username = "user")
void shouldGetAllPlanningHistory() {
var result = mvc.get().uri("/api/planning-history").exchange();
assertThat(result).hasStatusOk();
Expand All @@ -23,6 +24,7 @@ void shouldGetAllPlanningHistory() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldFilterPlanningHistoryByEntityType() {
var result = mvc.get().uri("/api/planning-history?entityType=FEATURE").exchange();
assertThat(result).hasStatusOk();
Expand All @@ -35,6 +37,7 @@ void shouldFilterPlanningHistoryByEntityType() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldFilterPlanningHistoryByEntityCode() {
var result = mvc.get().uri("/api/planning-history?entityCode=IDEA-1").exchange();
assertThat(result).hasStatusOk();
Expand All @@ -47,6 +50,7 @@ void shouldFilterPlanningHistoryByEntityCode() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldFilterPlanningHistoryByChangeType() {
var result = mvc.get().uri("/api/planning-history?changeType=CREATED").exchange();
assertThat(result).hasStatusOk();
Expand All @@ -59,6 +63,7 @@ void shouldFilterPlanningHistoryByChangeType() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldFilterPlanningHistoryByChangedBy() {
var result = mvc.get().uri("/api/planning-history?changedBy=admin").exchange();
assertThat(result).hasStatusOk();
Expand All @@ -71,6 +76,7 @@ void shouldFilterPlanningHistoryByChangedBy() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldReturnPagedResult() {
var result = mvc.get().uri("/api/planning-history?page=0&size=2").exchange();
assertThat(result).hasStatusOk();
Expand All @@ -90,6 +96,7 @@ void shouldReturnPagedResult() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldReturnEmptyPageWhenNoResults() {
var result = mvc.get()
.uri("/api/planning-history?entityCode=NONEXISTENT-CODE")
Expand All @@ -110,6 +117,7 @@ void shouldReturnEmptyPageWhenNoResults() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldGetFeatureHistory() {
var result = mvc.get().uri("/api/features/{code}/history", "IDEA-1").exchange();
assertThat(result).hasStatusOk();
Expand All @@ -122,6 +130,7 @@ void shouldGetFeatureHistory() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldGetReleaseHistory() {
var result =
mvc.get().uri("/api/releases/{code}/history", "IDEA-2023.3.8").exchange();
Expand All @@ -135,6 +144,7 @@ void shouldGetReleaseHistory() {
}

@Test
@WithMockOAuth2User(username = "user")
void shouldReturnEmptyHistoryForUnknownCode() {
var result =
mvc.get().uri("/api/features/{code}/history", "UNKNOWN-999").exchange();
Expand Down Expand Up @@ -230,4 +240,84 @@ void shouldTrackFeatureDeletion() {
.extracting(Number::intValue)
.satisfies(n -> assertThat(n).isGreaterThanOrEqualTo(1));
}

// ====== 401 Unauthorized Tests (No Authentication) =======

@Test
void shouldReturn401WhenAccessingPlanningHistoryWithoutAuthentication() {
var result = mvc.get().uri("/api/planning-history").exchange();

assertThat(result.getMvcResult().getResponse().getStatus()).isEqualTo(HttpStatus.UNAUTHORIZED.value());
}

@Test
void shouldReturn401WhenAccessingPlanningHistoryWithPaginationWithoutAuthentication() {
var result = mvc.get()
.uri("/api/planning-history?page=0&size=5&sort=changedAt,asc")
.exchange();

assertThat(result.getMvcResult().getResponse().getStatus()).isEqualTo(HttpStatus.UNAUTHORIZED.value());
}

@Test
void shouldReturn401WhenAccessingFeatureHistoryByCodeWithoutAuthentication() {
var result =
mvc.get().uri("/api/features/{code}/history", "TEST-FEATURE").exchange();

assertThat(result.getMvcResult().getResponse().getStatus()).isEqualTo(HttpStatus.UNAUTHORIZED.value());
}

@Test
void shouldReturn401WhenAccessingReleaseHistoryByCodeWithoutAuthentication() {
var result =
mvc.get().uri("/api/releases/{code}/history", "TEST-RELEASE").exchange();

assertThat(result.getMvcResult().getResponse().getStatus()).isEqualTo(HttpStatus.UNAUTHORIZED.value());
}

// ==== 403 Forbidden Tests (Authenticated but Insufficient Permissions) ====

@Test
@WithMockOAuth2User(
username = "restricteduser",
roles = {"GUEST"})
void shouldReturn403WhenAccessingPlanningHistoryWithInsufficientPermissions() {
var result = mvc.get().uri("/api/planning-history").exchange();

assertThat(result.getMvcResult().getResponse().getStatus()).isEqualTo(HttpStatus.FORBIDDEN.value());
}

@Test
@WithMockOAuth2User(
username = "restricteduser",
roles = {"GUEST"})
void shouldReturn403WhenAccessingPlanningHistoryWithPaginationWithInsufficientPermissions() {
var result = mvc.get()
.uri("/api/planning-history?page=0&size=5&sort=changedAt,asc")
.exchange();

assertThat(result.getMvcResult().getResponse().getStatus()).isEqualTo(HttpStatus.FORBIDDEN.value());
}

@Test
@WithMockOAuth2User(
username = "restricteduser",
roles = {"GUEST"})
void shouldReturn403WhenAccessingFeatureHistoryByCodeWithInsufficientPermissions() {
var result =
mvc.get().uri("/api/features/{code}/history", "TEST-FEATURE").exchange();

assertThat(result.getMvcResult().getResponse().getStatus()).isEqualTo(HttpStatus.FORBIDDEN.value());
}

@Test
@WithMockOAuth2User(
username = "restricteduser",
roles = {"GUEST"})
void shouldReturn403WhenAccessingReleaseHistoryByCodeWithInsufficientPermissions() {
var result =
mvc.get().uri("/api/releases/{code}/history", "TEST-RELEASE").exchange();

assertThat(result.getMvcResult().getResponse().getStatus()).isEqualTo(HttpStatus.FORBIDDEN.value());
}
}
Loading