fix: Roadmap summary overallCompletionPercentage is based on features instead of releases #179#265
Open
codecharlan wants to merge 1 commit intotoloka-agent/127-autofrom
Conversation
Author
|
@issue-validator validate the issue |
ElizavetaP
requested changes
Mar 19, 2026
|
Please also add an empty-result check for zero values: overallCompletionPercentage should be 0.0, not NaN. This can be added to the existing shouldReturnEmptyResultsForNonExistentOwner test, which already verifies the empty result for a non-existent owner. |
|
Please update FAIL_TO_PASS. |
codecharlan
force-pushed
the
bugfix/179-roadmap-summary-completion-percentage
branch
from
907ca39 to
2cc2cc8
Compare
ElizavetaP
reviewed
Mar 20, 2026
… instead of releases #179
codecharlan
force-pushed
the
bugfix/179-roadmap-summary-completion-percentage
branch
from
2cc2cc8 to
01cad1d
Compare
ElizavetaP
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for issue #179
FAIL_TO_PASS: RoadmapControllerIntegrationTests#shouldGetRoadmapWithoutFilters, RoadmapControllerIntegrationTests#shouldValidateCompleteSpecificationCompliance