nes-035: add requireActiveProfiles for dev profile#253
Open
kaleev wants to merge 1 commit intones/task/035-enforcer-require-active-profilefrom
Open
nes-035: add requireActiveProfiles for dev profile#253kaleev wants to merge 1 commit intones/task/035-enforcer-require-active-profilefrom
kaleev wants to merge 1 commit intones/task/035-enforcer-require-active-profilefrom
Conversation
caret: 'pom.xml:7404'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ "description": "With dev profile defined in pom.xml, suggest adding requireActiveProfiles rule for dev after requireJavaVersion", "notes": "Project has a dev profile with activeByDefault=true. After adding requireMavenVersion and requireJavaVersion, the model should suggest requireActiveProfiles with dev to enforce the profile is active. Unlike case 034 (no profiles, expect empty), here the profile context makes the suggestion valid.", "context": { "filepath": "pom.xml", "caret": 7404, "history": [ { "filepath": "pom.xml", "diff": "--- a/pom.xml\n+++ b/pom.xml\n@@ -189,6 +189,9 @@\n <requireMavenVersion>\n <version>3.2.5</version>\n </requireMavenVersion>\n+ <requireJavaVersion>\n+ <version>1.8</version>\n+ </requireJavaVersion>\n </rules>\n </configuration>\n </execution>" } ] } }